Fix some policies and graphql types #753
Conversation
Knerio
requested review from
Taucher2003 and
Copilot
and removed request for
Taucher2003
There was a problem hiding this comment.
Pull request overview
This PR addresses authorization inconsistencies and improves the GraphQL API structure for runtime-related types. The changes standardize authorization from read_flow to read_runtime for runtime components, fix the authorization name from read_datatype to read_data_type, rename fields for better clarity, and add missing relationships to the schema.
Key changes:
- Corrected authorization requirements from
read_flowtoread_runtimeforRuntimeFunctionDefinitionandRuntimeParameterDefinitiontypes - Fixed authorization name from
read_datatypetoread_data_typeinDataTypeType - Renamed
runtime_parameter_definitionsfield toparametersinRuntimeFunctionDefinitionfor improved API clarity - Added
identifierfield toRuntimeParameterDefinitionandruntimeFunctionDefinitionsfield toRuntime - Increased default pagination size from 50 to 120
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/policies/runtime_policy.rb | Added policy rule enabling read_data_type when user can read_runtime |
| app/policies/runtime_parameter_definition_policy.rb | New policy file delegating authorization to parent runtime_function_definition |
| app/graphql/types/runtime_type.rb | Added runtime_function_definitions field to expose runtime functions |
| app/graphql/types/runtime_parameter_definition_type.rb | Changed authorization from read_flow to read_runtime and added identifier field |
| app/graphql/types/runtime_function_definition_type.rb | Changed authorization from read_flow to read_runtime and renamed runtime_parameter_definitions to parameters |
| app/graphql/types/data_type_type.rb | Fixed authorization name from read_datatype to read_data_type |
| app/graphql/sagittarius_schema.rb | Increased default pagination size from 50 to 120 items |
| spec/graphql/types/runtime_type_spec.rb | Updated test to include new runtimeFunctionDefinitions field |
| spec/graphql/types/runtime_parameter_definition_type_spec.rb | Updated authorization expectation to read_runtime and added identifier field |
| spec/graphql/types/runtime_function_definition_type_spec.rb | Updated authorization expectation to read_runtime and field name to parameters |
| docs/graphql/object/runtimeparameterdefinition.md | Documented new identifier field |
| docs/graphql/object/runtimefunctiondefinition.md | Updated field name from runtimeParameterDefinitions to parameters |
| docs/graphql/object/runtime.md | Documented new runtimeFunctionDefinitions field |
| docs/graphql/object/runtimefunctiondefinitionedge.md | New documentation for edge type |
| docs/graphql/object/runtimefunctiondefinitionconnection.md | New documentation for connection type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2198395279 Status: Passed Job summariesrspec: [ee]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12337185206/artifacts/tmp/coverage/index.html rspec: [ce]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12337185204/artifacts/tmp/coverage/index.html rubocop718 files inspected, no offenses detected |
Co-authored-by: Niklas van Schrick <[email protected]> Signed-off-by: Dario Pranjic <[email protected]>
No description provided.